Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support alter source refresh schema for shared source #19740

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

follow up of #19649 (#19063). basically the same

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan mentioned this pull request Dec 10, 2024
9 tasks
@xxchan xxchan marked this pull request as ready for review December 10, 2024 08:28
@xxchan xxchan force-pushed the 12-03-feat_frontend_support_alter_shared_source branch from a52d3bd to 423935c Compare December 10, 2024 09:47
@xxchan xxchan force-pushed the 12-10-feat_frontend_support_alter_source_refresh_schema_for_shared_source branch from bcb8471 to fa6995e Compare December 10, 2024 09:47
@xxchan xxchan force-pushed the 12-03-feat_frontend_support_alter_shared_source branch from 423935c to d2a8cc2 Compare December 11, 2024 02:09
@xxchan xxchan force-pushed the 12-10-feat_frontend_support_alter_source_refresh_schema_for_shared_source branch from fa6995e to 8b18930 Compare December 11, 2024 02:10
Base automatically changed from 12-03-feat_frontend_support_alter_shared_source to main December 11, 2024 07:03
@graphite-app graphite-app bot requested a review from a team December 11, 2024 07:03
@xxchan xxchan force-pushed the 12-10-feat_frontend_support_alter_source_refresh_schema_for_shared_source branch from 8b18930 to 94076ac Compare December 11, 2024 07:04
Copy link
Member Author

xxchan commented Dec 11, 2024

Merge activity

  • Dec 11, 3:05 PM GMT+8: Graphite rebased this pull request as part of a merge.
  • Dec 11, 3:42 PM GMT+8: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite).

@xxchan xxchan enabled auto-merge December 11, 2024 07:22
@xxchan xxchan added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit ffe63f1 Dec 11, 2024
29 of 30 checks passed
@xxchan xxchan deleted the 12-10-feat_frontend_support_alter_source_refresh_schema_for_shared_source branch December 11, 2024 08:20
@xiangjinwu
Copy link
Contributor

https://buildkite.com/risingwavelabs/pull-request/builds/64241#0193b9e7-fcdd-43e5-9618-93b6866b6b30

e2e_test/source_inline/kafka/protobuf/alter_source_shared.slt .. [FAILED]
failed to run `e2e_test/source_inline/kafka/protobuf/alter_source_shared.slt`
Caused by:
    query result mismatch:
    [SQL] SELECT COUNT(*), MAX(age), MIN(age), SUM(age) FROM mv_user_more;
    [Diff] (-expected|+actual)
    -   25	104	0	510
    +   0 NULL NULL NULL
    at e2e_test/source_inline/kafka/protobuf/alter_source_shared.slt:74

@xxchan
Copy link
Member Author

xxchan commented Dec 12, 2024

I think this is the same issue as #19681 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants