fix(iceberg): fix iceberg engine table time travel #19747
Conversation
So is it changed to have the same syntax or not? |
They don't share the same syntax. For example, hummock table time travel doesn't support |
| @@ -15,6 +15,11 @@ select * from t; | |||
| ---- | |||
| 1 xxx | |||
|
|
|||
| query ?? | |||
| select * from t for system_time as of '2222-12-10 11:48:06'; | |||
There was a problem hiding this comment.
Does '2222-12-10 11:48:06' correspond to 7982020086000 or 7981991286000?
There was a problem hiding this comment.
I look at the implementation, currently all timestamp string in iceberg time travel (as well as hummock time travel) without explicit timezone will be considered to be UTC and don't respect the session timezone.
There was a problem hiding this comment.
Let's fix the current issue first and I will open another issue to track the timezone issue.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.