Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PR template #19762

Merged
merged 3 commits into from
Dec 12, 2024
Merged

chore: update PR template #19762

merged 3 commits into from
Dec 12, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Dec 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Vendor CLA into our repository.
  • Mark several task list item as OPTIONAL so that task-list-completed job does not require them for a green checkmark.
  • Comment out instructive texts in the task list to make it more concise.
  • Remove redundant information in the documentation section.
  • Fix orphan close tag </details> for the release note section and make it foldable.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao marked this pull request as ready for review December 11, 2024 09:32
## Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
- [ ] <!-- OPTIONAL --> My PR needs documentation updates. <!-- Please use the **Release note** section below to summarize the impact on users -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may break the action

if [[ $PR_BODY == *"- [x] My PR needs documentation updates."* ]]; then

@BugenZhao BugenZhao added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 8d3015a Dec 12, 2024
13 checks passed
@BugenZhao BugenZhao deleted the bz/outstanding-snake branch December 12, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants