Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduct credentials in rw_catalog #19845

Closed
wants to merge 2 commits into from
Closed

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

related #19689 & #19766

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@tabVersion tabVersion enabled auto-merge December 18, 2024 06:28
@fuyufjh
Copy link
Member

fuyufjh commented Dec 18, 2024

Weakly -1. IMO, This is not something that a system table should do.

@tabVersion tabVersion disabled auto-merge December 18, 2024 06:39
@fuyufjh
Copy link
Member

fuyufjh commented Dec 18, 2024

Weakly -1. IMO, This is not something that a system table should do.

Just saying, for example, if we develop a rw_dump tool like pg_dump, it will fetch all information from system catalog. The system table is supposed to be a source of truth to be read for external tools.


I think we are able to mitigate the issue via proper privilge check #19722.

@tabVersion
Copy link
Contributor Author

I think we are able to mitigate the issue via proper privilge check #19722.

+1 for this. Limiting the privilege to rw_catalog can prevent leaking.

Another motivation for the PR is the cloud team also don't want to display the credentials on the portal, there has to be a mosaic step.

@tabVersion tabVersion closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants