feat(stream): add append_only in proto stream node #2020
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2020 +/- ##
=======================================
Coverage 70.65% 70.65%
=======================================
Files 629 629
Lines 80967 80987 +20
=======================================
+ Hits 57208 57223 +15
- Misses 23759 23764 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
| @@ -581,6 +582,7 @@ where | |||
| fields: chain_node.upstream_fields.clone(), | |||
| operator_id: merge_node.operator_id, | |||
| identity: "MergeExecutor".to_string(), | |||
| append_only: stream_node.append_only, | |||
There was a problem hiding this comment.
Can we determine append_only of upstream node solely from the StreamTableScan's append_only property?
There was a problem hiding this comment.
I saw that append_only of StreamTableScan is always false... So I think we can follow the append_only property given by frontend for now. If there's issue after we implement the full append-only inference, let's fix it later.
There was a problem hiding this comment.
In fact I think the information should be in the catalog of the mv...
| @@ -164,6 +165,7 @@ impl StreamTableScan { | |||
| } else { | |||
| "".into() | |||
| }, | |||
| append_only: false, // TODO | |||
| @@ -127,6 +127,7 @@ impl StreamTableScan { | |||
| pk_indices: pk_indices.clone(), | |||
| input: vec![], | |||
| fields: vec![], // TODO: fill this later | |||
| append_only: true, | |||
There was a problem hiding this comment.
For L117 (MergeNode), also should be self.append_only?
What's changed and what's your intention?
add append_only in proto stream node
Checklist
Refer to a related PR or issue link (optional)