feat(optimizer): outer join simplify #2349
Merged
+123
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2349 +/- ##
=======================================
Coverage 71.07% 71.08%
=======================================
Files 675 675
Lines 84619 84652 +33
=======================================
+ Hits 60145 60172 +27
- Misses 24474 24480 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
xiangjinwu
approved these changes
May 6, 2022
| for expr in &predicate.conjunctions { | ||
| if let ExprImpl::FunctionCall(func) = expr { | ||
| match func.get_expr_type() { | ||
| risingwave_pb::expr::expr_node::Type::Equal |
There was a problem hiding this comment.
use crate::expr::ExprType rather than risingwave_pb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
add outer join simplify in the filter-join rule. now it is just a naive implementation for comparison expression, we can give a more general implementation with constant folding in future
Checklist
Refer to a related PR or issue link (optional)