-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(optimizer): fix distribution satisfy condition #2447
Conversation
Will this possibly fix the issue of left semi join TPC-Hs? cc @yuhao-su |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need fix conflict.
The plan of Q18, Q20 gets changed. Maybe we can try them after this PR gets merged. |
It's certainly possible since a incorrect plan can affect a lot. I'll try those tpchs see if they work/ |
Codecov Report
@@ Coverage Diff @@
## main #2447 +/- ##
==========================================
+ Coverage 71.28% 71.31% +0.02%
==========================================
Files 688 688
Lines 88174 88250 +76
==========================================
+ Hits 62855 62932 +77
+ Misses 25319 25318 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Time to try some more TPC-H queries 🥵🥵 cc @yuhao-su |
What's changed and what's your intention?
HashShard(a,b) means no records with same (a,b) on the different shards.
HashShard(a) means no records same (a) on the different shards.
then
HashShard(a)
satisfyHashShard(a, b)
.Checklist
Refer to a related PR or issue link (optional)
#2442
#2454