-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement pg_catalog upon local execution mode #3387
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3387 +/- ##
==========================================
- Coverage 73.73% 73.58% -0.15%
==========================================
Files 761 766 +5
Lines 104506 104879 +373
==========================================
+ Hits 77054 77175 +121
- Misses 27452 27704 +252
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scheduler and Batch execution parts LGTM!
Generally LGTM |
@yezizp2012 @xiangjinwu Are these changes visible to users? Does it mean that in local execution mode, RisingWave supports casts, namespaces, and types exactly the same as in PG? Thanks. |
|
@xiangjinwu Thanks for the detailed explanation! I think it makes senses that we do not disclose these details until the bigger features are completed. |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
As title, implemented
pg_type
/pg_namespace
/pg_cast
and some other rules for ddl:SysRowSeqScanExecutor
to support scanning on system table, only works in local execution mode.pg_catalog
schema and system tables for all new created database, and drop them when database dropped.pg_
.pg_catalog
.todo:
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
Part of #2954