-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): batched iterator & e2e tests with in-memory state store #5322
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Codecov Report
@@ Coverage Diff @@
## main #5322 +/- ##
========================================
Coverage 74.00% 74.00%
========================================
Files 900 900
Lines 139166 139293 +127
========================================
+ Hits 102990 103084 +94
- Misses 36176 36209 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my part lgtm
…ate-store Signed-off-by: Bugen Zhao <i@bugenzhao.com>
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR introduces a batched iterator for memory state store, so that we don't clone the full range at once when starting iteration.
This PR also restores the capability of enabling memory state store with
risedev
, and adds a new step of running parallel e2e tests with in-memory state store. Hope this'll be helpful for us to debug.Note that the in-memory state store should still not be used for production, as
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)