-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): support basic CREATE / DROP FUNCTION
#7265
Conversation
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This PR establishes the basic logic of creating and dropping functions.
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Codecov Report
@@ Coverage Diff @@
## main #7265 +/- ##
==========================================
- Coverage 73.19% 73.02% -0.18%
==========================================
Files 1058 1063 +5
Lines 169375 169707 +332
==========================================
- Hits 123980 123921 -59
- Misses 45395 45786 +391
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Runji Wang <wangrunji0408@163.com>
This PR adds necessary code to frontend to support basic `CREATE FUNCTION` and `DROP FUNCTION` statement. The supported syntax of `CREATE FUNCTION` is a subset of [postgres](https://www.postgresql.org/docs/current/sql-createfunction.html)': ```sql create function func(int, int) returns int as 'http://localhost:8815' language arrow_flight; ``` This PR only stores the given information in catalog. They will be used to connect the external function service in the future. At last, since I'm new to the frontend and not familar with the code, please feel free to point out anything I have missed. Thanks! 🥹 Approved-By: chenzl25
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds necessary code to frontend to support basic
CREATE FUNCTION
andDROP FUNCTION
statement.The supported syntax of
CREATE FUNCTION
is a subset of postgres':This PR only stores the given information in catalog. They will be used to connect the external function service in the future.
At last, since I'm new to the frontend and not familar with the code, please feel free to point out anything I have missed. Thanks! 🥹
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)