Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): fix json parser #7447

Merged
merged 3 commits into from
Jan 17, 2023
Merged

fix(source): fix json parser #7447

merged 3 commits into from
Jan 17, 2023

Conversation

waruto210
Copy link
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • fix json parser

Checklist

- [ ] I have written necessary rustdoc comments
- [ ] I have added necessary unit tests and integration tests
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
- [ ] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

fix #7446
caused by #7256
update simd-json: tabVersion/simd-json#1

@github-actions github-actions bot added the type/fix Bug fix label Jan 17, 2023
@tabVersion
Copy link
Contributor

introduced by a fix in the upstream tabVersion/simd-json#1

@waruto210 waruto210 force-pushed the waruto/fix-json-parser branch from cd1ab5a to add39c4 Compare January 17, 2023 13:10
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #7447 (11528b3) into main (a6e41d2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7447      +/-   ##
==========================================
- Coverage   72.91%   72.91%   -0.01%     
==========================================
  Files        1071     1071              
  Lines      172463   172463              
==========================================
- Hits       125759   125746      -13     
- Misses      46704    46717      +13     
Flag Coverage Δ
rust 72.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/source/src/parser/canal/simd_json_parser.rs 63.03% <ø> (ø)
src/batch/src/executor/group_top_n.rs 68.42% <0.00%> (-6.44%) ⬇️
src/batch/src/task/task_execution.rs 53.66% <0.00%> (-0.53%) ⬇️
src/object_store/src/object/mem.rs 87.12% <0.00%> (-0.38%) ⬇️
src/common/src/cache.rs 97.31% <0.00%> (-0.23%) ⬇️
src/object_store/src/object/mod.rs 51.29% <0.00%> (-0.22%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.84% <0.00%> (-0.16%) ⬇️
src/meta/src/hummock/manager/mod.rs 79.98% <0.00%> (+0.06%) ⬆️
src/storage/src/hummock/compactor/mod.rs 83.48% <0.00%> (+0.15%) ⬆️
src/meta/src/manager/cluster.rs 77.11% <0.00%> (+0.24%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 9ed0189 into main Jan 17, 2023
@mergify mergify bot deleted the waruto/fix-json-parser branch January 17, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(source): source does not insert bigint
2 participants