-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(notification): allow multiple observer nodes on one worker #8210
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8210 +/- ##
=======================================
Coverage 71.58% 71.58%
=======================================
Files 1131 1131
Lines 182679 182720 +41
=======================================
+ Hits 130775 130809 +34
- Misses 51904 51911 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @Gun9niR, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
Hey @Gun9niR, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously, if we want to send a notification by
WorkerKey
, it would be sent to all observer nodes of that worker, causing panic on unaccepted message types. This PR fixes it.Another possible implementation would be using a single remote connection for each worker and dispatching notifications from
ObserverManager
on the worker node side, but that would affect the timeliness of notification handling.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note