Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add missing sqlsmith queries #8214

Merged
merged 2 commits into from
Feb 28, 2023
Merged

fix(ci): add missing sqlsmith queries #8214

merged 2 commits into from
Feb 28, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Feb 28, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • ban tokio_postgres::Client::query via clippy.
  • Add sanity check if queries not generated.
  • re-generate all queries (previously missing 2 sets of queries).
  • Nest LHS of InSubquery to avoid ambiguity.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Bug fix label Feb 28, 2023
@kwannoel kwannoel requested a review from lmatz February 28, 2023 01:50
@kwannoel kwannoel changed the title fix(ci): add missing queries fix(ci): add missing sqlsmith queries Feb 28, 2023
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to zip these queries?
not sure how much size do they take

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #8214 (649a8cf) into main (8e9f344) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8214      +/-   ##
==========================================
- Coverage   71.77%   71.77%   -0.01%     
==========================================
  Files        1130     1130              
  Lines      181601   181601              
==========================================
- Hits       130346   130340       -6     
- Misses      51255    51261       +6     
Flag Coverage Δ
rust 71.77% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 64.43% <0.00%> (-1.04%) ⬇️
...frontend/src/scheduler/hummock_snapshot_manager.rs 60.00% <0.00%> (-0.48%) ⬇️
src/object_store/src/object/mod.rs 48.45% <0.00%> (-0.42%) ⬇️
src/object_store/src/object/mem.rs 86.87% <0.00%> (-0.39%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.62% <0.00%> (-0.32%) ⬇️
src/meta/src/hummock/manager/mod.rs 77.76% <0.00%> (-0.07%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.69% <0.00%> (ø)
src/common/src/cache.rs 97.26% <0.00%> (+0.10%) ⬆️
src/batch/src/task/task_execution.rs 52.13% <0.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kwannoel
Copy link
Contributor Author

Is it better to zip these queries? not sure how much size do they take

Actually... even if we zip, each time we have new features, and re-generate the 100 queries, there will be large diff, and probably takes up much space in the repository.
I think these queries perhaps should not be checked-in here.

Maybe just store on s3 / have cron on buildkite to store it as a generated artifact / store in separate repository (but I don't think it makes sense to version control it for now).

Will open an issue to write down some thoughts I have regarding this and #7967 (comment).

Merging this first.

@kwannoel kwannoel added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit 42324a9 Feb 28, 2023
@kwannoel kwannoel deleted the kwannoel/fix-ci branch February 28, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants