Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proto): refactor cell based table and rowSeqScan plan #835

Merged
merged 7 commits into from
Mar 11, 2022

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Mar 11, 2022

What's changed and what's your intention?

  • rename the rowTable to CellBasedTable.
  • change the RowSeqScan proto with the CellBasedTableDesc, but now we are hard to get pk_desc in frontend so it was not actually used

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #835 (06fd293) into main (054b61d) will decrease coverage by 0.22%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               main     #835      +/-   ##
============================================
- Coverage     72.24%   72.01%   -0.23%     
  Complexity     2766     2766              
============================================
  Files           923      927       +4     
  Lines         53758    54086     +328     
  Branches       1787     1787              
============================================
+ Hits          38838    38951     +113     
- Misses        14030    14245     +215     
  Partials        890      890              
Flag Coverage Δ
java 61.22% <100.00%> (ø)
rust 76.45% <0.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/batch/src/executor/row_seq_scan.rs 45.94% <0.00%> (ø)
rust/storage/src/table/cell_based_table.rs 0.00% <0.00%> (ø)
...m/risingwave/planner/rel/physical/RwBatchScan.java 100.00% <100.00%> (ø)
rust/meta/src/model/stream.rs 71.21% <0.00%> (-7.36%) ⬇️
rust/prost/src/imp.rs 11.76% <0.00%> (-6.42%) ⬇️
rust/frontend/src/session.rs 96.38% <0.00%> (-2.08%) ⬇️
rust/meta/src/stream/stream_manager.rs 72.10% <0.00%> (-0.91%) ⬇️
rust/meta/src/hummock/compaction.rs 81.06% <0.00%> (-0.60%) ⬇️
rust/meta/src/stream/meta.rs 48.86% <0.00%> (-0.54%) ⬇️
rust/meta/src/model/mod.rs 76.31% <0.00%> (ø)
... and 33 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@st1page st1page merged commit 9f2387b into main Mar 11, 2022
@st1page st1page deleted the sts/refactor_cell_based_table branch March 11, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants