Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase scale test timeout #8409

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix: Increase scale test timeout #8409

merged 2 commits into from
Mar 8, 2023

Conversation

liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Mar 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

RT

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.

@liurenjie1024 liurenjie1024 added this pull request to the merge queue Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #8409 (edf18cf) into main (52c868c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8409      +/-   ##
==========================================
- Coverage   71.58%   71.58%   -0.01%     
==========================================
  Files        1135     1135              
  Lines      185118   185118              
==========================================
- Hits       132514   132508       -6     
- Misses      52604    52610       +6     
Flag Coverage Δ
rust 71.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/source/src/row_id.rs 90.90% <0.00%> (-1.14%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 64.43% <0.00%> (-1.04%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.19% <0.00%> (-0.39%) ⬇️
src/meta/src/hummock/manager/mod.rs 78.83% <0.00%> (-0.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yezizp2012
Copy link
Contributor

How about decrease test num or increase timeout for scaling test in main-cron job as well?

Merged via the queue into main with commit f482f1b Mar 8, 2023
@liurenjie1024 liurenjie1024 deleted the renjie/fix_timeout branch March 8, 2023 02:49
@liurenjie1024
Copy link
Contributor Author

How about decrease test num or increase timeout for scaling test in main-cron job as well?

Let's see if this can resolve the failure and decided to add whether we need to add it later.

stdrc pushed a commit that referenced this pull request Mar 8, 2023
BugenZhao added a commit that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants