Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor, frontend): StreamHopWindow executor should derive window expr in frontend #8415

Merged
merged 17 commits into from
Mar 8, 2023

Conversation

jon-chuang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Stream Hop executor should derive expr in frontend. e2e test previously panicked with variable duration interval due to not inlining session timezone.

Notes:

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.

Related

Fixes part of: #7334

@github-actions github-actions bot added the type/fix Bug fix label Mar 8, 2023
@jon-chuang jon-chuang changed the title fix(executor, frontend): BatchHopWindow executor should derive window expr in frontend fix(executor, frontend): StreamHopWindow executor should derive window expr in frontend Mar 8, 2023
@jon-chuang jon-chuang mentioned this pull request Mar 8, 2023
13 tasks
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #8415 (fdbfd3d) into main (f4817e9) will decrease coverage by 0.01%.
The diff coverage is 71.71%.

@@            Coverage Diff             @@
##             main    #8415      +/-   ##
==========================================
- Coverage   71.64%   71.64%   -0.01%     
==========================================
  Files        1135     1135              
  Lines      185600   185621      +21     
==========================================
+ Hits       132978   132991      +13     
- Misses      52622    52630       +8     
Flag Coverage Δ
rust 71.64% <71.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/hop_window.rs 68.18% <ø> (ø)
src/frontend/src/optimizer/plan_node/stream.rs 15.27% <0.00%> (-0.52%) ⬇️
src/stream/src/from_proto/hop_window.rs 0.00% <0.00%> (ø)
src/stream/src/executor/hop_window.rs 87.07% <91.30%> (+6.81%) ⬆️
...tend/src/optimizer/plan_node/logical_hop_window.rs 95.83% <100.00%> (+0.01%) ⬆️
...ntend/src/optimizer/plan_node/stream_hop_window.rs 99.13% <100.00%> (+0.52%) ⬆️
src/source/src/row_id.rs 90.90% <0.00%> (-1.14%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 64.94% <0.00%> (-0.52%) ⬇️
...frontend/src/scheduler/hummock_snapshot_manager.rs 60.00% <0.00%> (-0.48%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.19% <0.00%> (-0.39%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liurenjie1024
Copy link
Contributor

I think this may break existing pipeline.

@jon-chuang
Copy link
Contributor Author

I think this may break existing pipeline.

Hmm, why is that?

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st1page
Copy link
Contributor

st1page commented Mar 8, 2023

I think this may break existing pipeline.

Hmm, why is that?

I think it is because we persist in the streaming plan proto in the meta store and our new implementation can not handle the old plan.

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is a breaking change and seems to be unable to provide backward compatibility.

@jon-chuang jon-chuang added this pull request to the merge queue Mar 8, 2023
Merged via the queue into main with commit abe0bfe Mar 8, 2023
@jon-chuang jon-chuang deleted the jon/stream-hop-window-frontend-derive branch March 8, 2023 13:06
soundOfDestiny pushed a commit that referenced this pull request Mar 9, 2023
…dow expr in frontend (#8415)

Co-authored-by: jon-chuang <jon-chuang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants