Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): support NULLS {FIRST | LAST} #8485

Merged
merged 34 commits into from
Mar 19, 2023
Merged

feat(common): support NULLS {FIRST | LAST} #8485

merged 34 commits into from
Mar 19, 2023

Commits on Mar 11, 2023

  1. support switching nulls smallest/largest during memcmp serialization 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    023ea26 View commit details
    Browse the repository at this point in the history

  2. basic support for nulls first/last done, batch queries now work 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    da141ce View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Merge branch 'main' into rc/nulls-first-last-new

    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    9abed57 View commit details
    Browse the repository at this point in the history

  2. appease the typo checker 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6ffe60f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into rc/nulls-first-last-new 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    3fee6c0 View commit details
    Browse the repository at this point in the history

  4. support nulls first/last for batch string/array_agg 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    939f732 View commit details
    Browse the repository at this point in the history

  5. move ScalarImpl::encoding_data_size to `memcmp_encoding::calculate_… 

    …encoded_size`

Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    cd8c610 View commit details
    Browse the repository at this point in the history

  6. remove unused import 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    9752ea8 View commit details
    Browse the repository at this point in the history

  7. remove use of Direction from row_seq_scan 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    302825b View commit details
    Browse the repository at this point in the history

  8. remove derive_order_type_from_order_by_expr 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    244ed10 View commit details
    Browse the repository at this point in the history

  9. remove use of Direction from describe.rs 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    326605f View commit details
    Browse the repository at this point in the history

  10. remove use of Direction from backfill.rs 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    ebe113e View commit details
    Browse the repository at this point in the history

  11. fix 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    afdb4fa View commit details
    Browse the repository at this point in the history

  12. unittests now compile 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0cbb4eb View commit details
    Browse the repository at this point in the history

  13. move Deserialize::new call inside calculate_encoded_size 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    7ff29de View commit details
    Browse the repository at this point in the history

  14. fix output_requires_order_on_group_keys 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    cd2b556 View commit details
    Browse the repository at this point in the history

  15. enhance unit tests for memcmp encoding 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    52f92ff View commit details
    Browse the repository at this point in the history

  16. add unit test for OrderType 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    126619c View commit details
    Browse the repository at this point in the history

  17. merge encode_row and encode_row_ref 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    a039f2f View commit details
    Browse the repository at this point in the history

  18. add unit tests 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    382d41c View commit details
    Browse the repository at this point in the history

  19. minor 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    657c998 View commit details
    Browse the repository at this point in the history

  20. update dashbaord things 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0c41112 View commit details
    Browse the repository at this point in the history

  21. fix test_describe_handler 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    2eba1a6 View commit details
    Browse the repository at this point in the history

  22. fix typo 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e20d587 View commit details
    Browse the repository at this point in the history

  23. add e2e tests for nulls first/last 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    41cfe77 View commit details
    Browse the repository at this point in the history

  24. update planner tests 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6961ebc View commit details
    Browse the repository at this point in the history

  25. fix format 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    12ca4fa View commit details
    Browse the repository at this point in the history

  26. final clean 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    d57bf4d View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. fix show.slt 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b862295 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. hide NULLS FIRST|LAST if it's default 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    7db1dad View commit details
    Browse the repository at this point in the history

  2. update planner tests 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    8e552b5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into rc/nulls-first-last-new 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    d98a967 View commit details
    Browse the repository at this point in the history

  4. hide Direction and NullsAre 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    1e84035 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. rename vars 

    Signed-off-by: Richard Chien <stdrc@outlook.com>
    @stdrc
    stdrc committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    b32c2a5 View commit details
    Browse the repository at this point in the history