Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate console sink #8950

Merged
merged 7 commits into from
Apr 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/connector-node-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,6 @@ jobs:
echo "Jdbc sink test failed"
exit 1
fi

if python3 integration_tests.py --print_sink; then
echo "Print sink test passed"
else
echo "Print sink test failed"
exit 1
fi
cd ..
echo "all jdbc tests passed"

Expand Down
2 changes: 1 addition & 1 deletion e2e_test/ddl/invalid_operation.slt
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ drop view src;

# 4.6 sink
statement ok
CREATE SINK sink FROM mv WITH (connector='console', prefix='DEBUG', suffix='');
CREATE SINK sink FROM mv WITH (connector='blackhole');

# FIXME: improve the error message
statement error not found
Expand Down
7 changes: 0 additions & 7 deletions java/connector-node/python-client/integration_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,6 @@ def validate_jdbc_sink(input_file):
exit(1)


def test_print_sink(input_file):
test_sink("print", {}, input_file)


def test_iceberg_sink(input_file):
test_sink("iceberg",
{"type":"append-only",
Expand Down Expand Up @@ -192,7 +188,6 @@ def test_deltalake_sink(input_file):
parser = argparse.ArgumentParser(formatter_class=argparse.ArgumentDefaultsHelpFormatter)
parser.add_argument('--file_sink', action='store_true', help="run file sink test")
parser.add_argument('--jdbc_sink', action='store_true', help="run jdbc sink test")
parser.add_argument('--print_sink', action='store_true', help="run print sink test")
parser.add_argument('--iceberg_sink', action='store_true', help="run iceberg sink test")
parser.add_argument('--upsert_iceberg_sink', action='store_true', help="run upsert iceberg sink test")
parser.add_argument('--deltalake_sink', action='store_true', help="run deltalake sink test")
Expand All @@ -202,8 +197,6 @@ def test_deltalake_sink(input_file):
test_file_sink(args.input_file)
if args.jdbc_sink:
test_jdbc_sink(args.input_file)
if args.print_sink:
test_print_sink(args.input_file)
if args.iceberg_sink:
test_iceberg_sink(args.input_file)
if args.upsert_iceberg_sink:
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
public class SinkUtils {
public static SinkFactory getSinkFactory(String sinkType) {
switch (sinkType) {
case "print":
case "connector-node-print":
return new PrintSinkFactory();
case "file":
return new FileSinkFactory();
case "jdbc":
Expand Down

This file was deleted.

Loading