-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source): create source with connection/drop connection #9128
Conversation
…-schema' into weili/connection-in-schema
Codecov Report
@@ Coverage Diff @@
## main #9128 +/- ##
==========================================
- Coverage 70.89% 70.83% -0.06%
==========================================
Files 1203 1201 -2
Lines 200839 200992 +153
==========================================
- Hits 142377 142365 -12
- Misses 58462 58627 +165
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Connection
from root catalog to schema catalogCreate Connection
andShow Connections
statements according to the changesDrop Connection
statementMockConnection
connection type for testingThis is a followup of the last pr: #8907
Related: #8771, #9119
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Types of user-facing changes
Release note
CREATE SOURCE
with a privatelink connection. Syntax:DROP CONNECTION
. Syntax: