fix(frontend): support drop function without arguments
#9561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
github-actions
bot
added
type/fix
xxchan
reviewed
May 3, 2023
Comment on lines
+64
to
+77
| None => match reader.get_functions_by_name(db_name, schema_path, &function_name) { | ||
| Ok((functions, schema_name)) => { | ||
| if functions.len() > 1 { | ||
| return Err(ErrorCode::CatalogError(format!("function name {function_name:?} is not unique\nHINT: Specify the argument list to select the function unambiguously.").into()).into()); | ||
| } | ||
| Ok(( | ||
| functions.into_iter().next().expect("no functions"), | ||
| schema_name, | ||
| )) | ||
| } | ||
| Err(e) => Err(e), | ||
| }, | ||
| }; | ||
| match res { |
There was a problem hiding this comment.
This looks a little spaghetti, but I don't have an immediate idea to improve it 🤪
There was a problem hiding this comment.
Agree. it's quick-and-dirty. 🤪
xxchan
approved these changes
May 3, 2023
xxchan
reviewed
May 3, 2023
Comment on lines
+488
to
+490
| if functions.is_empty() { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
I thought it might panic when this function returns a Some(vec![]). So I added these lines to prevent it.
Codecov Report
@@ Coverage Diff @@
## main #9561 +/- ##
==========================================
- Coverage 70.74% 70.72% -0.03%
==========================================
Files 1234 1234
Lines 206718 206757 +39
==========================================
- Hits 146243 146228 -15
- Misses 60475 60529 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yezizp2012
approved these changes
May 3, 2023
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
drop function foo;will succeed only when there's exactly one function namedfoo.Here are some examples:
This PR also improved the error message when function is not found.
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
If the function name is unique in its schema, it can be referred to without an argument list:
Note that this is different from
which refers to a function with zero arguments, whereas the first variant can refer to a function with any number of arguments, including zero, as long as the name is unique.