Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ignore criterion in hakari #9734

Merged
merged 2 commits into from
May 10, 2023
Merged

build: ignore criterion in hakari #9734

merged 2 commits into from
May 10, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented May 10, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Because it's a dev-dependency for bench, and won't be needed most of the time. BTW, we can also avoid compiling clap v3. 😄

image

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@xxchan xxchan requested a review from BugenZhao May 10, 2023 11:47
@xxchan xxchan enabled auto-merge May 10, 2023 11:47
@xxchan xxchan added this pull request to the merge queue May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #9734 (4f72ee8) into main (8874bf5) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9734      +/-   ##
==========================================
- Coverage   70.98%   70.96%   -0.02%     
==========================================
  Files        1245     1245              
  Lines      208369   208369              
==========================================
- Hits       147913   147872      -41     
- Misses      60456    60497      +41     
Flag Coverage Δ
rust 70.96% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
@xxchan xxchan added this pull request to the merge queue May 10, 2023
Merged via the queue into main with commit e6dc622 May 10, 2023
@xxchan xxchan deleted the xxchan/managerial-antelope branch May 10, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants