Humdrum: Improve element visibility for suppressed tokens #3436

WolfgangDrescher · 2023-05-30T20:10:08Z

Demo data:

**kern	**kern
=7	=7
*^	*^
2B;yyy	2GG;yy	2g;yy	2d;yyy
=:|!	=:|!	=:|!	=:|!
*	*	*	*
4dyy	4GGyy	4byy	[4gyy
=8	=8	=8	=8
4dyy	4GGyy	4byy	8gL]yy
.	.	.	8f#Jyy
4cyy	4AAyy	4ccyy	8eLyy
.	.	.	8f#Jyy
8BLyy	4BByy	4ddyy	[4gyy
8AJyy	.	.	.
=9	=9	=9	=9
8BLyy	4.BByy	4.ddyy	8gL]yy
8cJyy	.	.	8aJyy
4dyy	.	.	8gLyy
.	8AAyy	8ccyy	8f#Jyy
4dyy	4GGyy	4byy	4gyy
=10	=10	=10	=10
2d;yyy	2D;yy	2a;yy	2f#;yyy
4Byy	[4Eyy	4gyy	4eyy
=	=	=	=
*v	*v	*	*
*	*v	*v
*-	*-

Before:

After:

Questions:

@craigsapp Should I implement this for HumdrumInput::insertGBeam as well?
I'm not sure if this could also be relevant for HumdrumInput::insertBeamSpan
beam->SetType("invisible"); does not seem to have any effect for the element visibility and there is no beam::SetVisible member for beams. I fixed this for now with beam->SetColor("transparent") but I'm sure there must be a better solution. Any suggestions?

WolfgangDrescher · 2023-05-30T20:10:36Z

src/iohumdrum.cpp

+        beam->SetType("invisible");
+        beam->SetColor("transparent");


Any ideas how to improve this?

I think this is the best way. This is equivalent to visibility: none in CSS: space will be allocated to the beams but they will not be shown. This should be sufficient as long as you don't mind the extra vertical space between staves that this may create.

craigsapp · 2023-05-31T01:34:06Z

beam->SetType("invisible"); does not seem to have any effect for the element visibility and there is no beam::SetVisible member for beams.

the @type attribute is a more informal system, so it is useful to include for analytic purposes. And at least in general it is not used by verovio for rendering (that is usually done by @form when doing some sort of special rendering in verovio). The @type parameter is converted into a @class attribute in the SVG output from verovio. So you could add a verovio option to the Humdrum file to cause the elements with a transparent class label to be colored transparent:

!!!verovio: svgCss g.invisible { fill: transparent; stroke: transparent; }

Or perhaps equivalently:

!!!verovio: svgCss g.invisible { visibility: none; }

I notice that ledger lines are still visible when notes are set to transparent. Is there also a way to control the color of ledger lines @lpugin? Maybe by adding a verovio option such as --color-ledger-lines-as-note might work (should also work for chords).

Click to view MEI data for above example

<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="https://music-encoding.org/schema/dev/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="https://music-encoding.org/schema/dev/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="5.0.0-dev">
 <meiHead>
  <fileDesc>
   <titleStmt>
    <title />
   </titleStmt>
   <pubStmt />
  </fileDesc>
  <encodingDesc>
   <appInfo>
    <application isodate="2023-05-30T18:03:36" version="3.16.0-dev-b62cd9f-dirty">
     <name>Verovio</name>
     <p>Transcoded from Humdrum</p>
    </application>
   </appInfo>
  </encodingDesc>
  <workList>
   <work>
    <title />
   </work>
  </workList>
 </meiHead>
 <music>
  <body>
   <mdiv xml:id="mjwj3tb">
    <score xml:id="s1eybwzi">
     <scoreDef xml:id="s1edwjv1">
      <staffGrp xml:id="si7c6ug">
       <staffDef xml:id="staffdef-L1F1" n="1" lines="5">
        <clef xml:id="c1t15tkf" shape="G" line="2" />
       </staffDef>
      </staffGrp>
     </scoreDef>
     <section xml:id="section-L1F1">
      <measure xml:id="measure-L1">
       <staff xml:id="staff-L1F1" n="1">
        <layer xml:id="layer-L1F1N1" n="1">
         <note xml:id="note-L3F1" dur="4" oct="4" pname="c" accid.ges="n" />
         <note xml:id="note-L4F1" dur="4" oct="4" pname="d" accid.ges="n" />
         <note xml:id="note-L5F1" dur="4" oct="4" pname="e" accid.ges="n" />
         <note xml:id="note-L6F1" dur="4" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
      </measure>
      <measure xml:id="measure-L7">
       <staff xml:id="staff-L7F1N1" n="1">
        <layer xml:id="layer-L7F1N1" n="1">
         <note xml:id="note-L9F1" dur="4" oct="4" pname="c" color="transparent" accid.ges="n" />
         <note xml:id="note-L10F1" dur="4" oct="4" pname="d" color="transparent" accid.ges="n" />
         <note xml:id="note-L11F1" dur="4" oct="4" pname="e" color="transparent" accid.ges="n" />
         <note xml:id="note-L12F1" dur="4" oct="4" pname="g" color="transparent" accid.ges="n" />
        </layer>
       </staff>
      </measure>
     </section>
    </score>
   </mdiv>
  </body>
 </music>
</mei>

I think it would be good to to create *invis and *Xinvis to be mapped to *color:transparent and *color:black. Then yy would not need to be added to every note that needs to be invisible (this could also be used for **dynam and **text).

@craigsapp Should I implement this for HumdrumInput::insertGBeam as well?

Yes, that would be good (otherwise there will be unattached grace beams like there were with regular beams).

If the purpose of making the music invisible is for students to composite the missing music, then there is a question of security since the notes are still present in the MEI/SVG data and they might eventually figure that out... In that case maybe add *blank and *Xblank which will convert notes into invisible rests.

lpugin · 2023-06-17T21:06:09Z

@craigsapp could you review this and the other one? Thanks

WolfgangDrescher · 2023-06-19T09:47:49Z

Commit 47616c3 fixes the same bug for grace notes

Before:

After:

Data:

**kern
16bqLyy
16ddqJyy
1cc
*-

WolfgangDrescher · 2023-06-19T09:53:18Z

Having something like *blank does seem useful. But there is no urgent need for me right now. Same for *invis as it is currently easier to add yy to all data tokens with shed than adding an additional tandem interpretation in the browser.

(Maybe we should add a new filter that allows adding new tandem interpretations.)

WolfgangDrescher added 2 commits May 30, 2023 21:58

Ignore tie when token is suppressed with yy signifier

0338fd8

Ignore beam when token is suppressed with yy signifier

07b758a

WolfgangDrescher commented May 30, 2023

View reviewed changes

lpugin requested a review from craigsapp June 6, 2023 08:50

Ignore grace note beam when token is suppressed with yy signifier

47616c3

WolfgangDrescher added 2 commits June 19, 2023 11:48

Improve comment

aab30d1

Document insertGBeam method

87e1cf4

WolfgangDrescher marked this pull request as ready for review June 19, 2023 10:09

WolfgangDrescher changed the base branch from develop to develop-humdrum June 19, 2023 10:11

craigsapp approved these changes Jun 19, 2023

View reviewed changes

craigsapp merged commit 3bb2fff into rism-digital:develop-humdrum Jun 19, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Humdrum: Improve element visibility for suppressed tokens #3436

Humdrum: Improve element visibility for suppressed tokens #3436

WolfgangDrescher commented May 30, 2023

WolfgangDrescher May 30, 2023

craigsapp May 31, 2023

craigsapp commented May 31, 2023 •

edited

Loading

lpugin commented Jun 17, 2023

WolfgangDrescher commented Jun 19, 2023

WolfgangDrescher commented Jun 19, 2023

Humdrum: Improve element visibility for suppressed tokens #3436

Humdrum: Improve element visibility for suppressed tokens #3436

Conversation

WolfgangDrescher commented May 30, 2023

Questions:

WolfgangDrescher May 30, 2023

Choose a reason for hiding this comment

craigsapp May 31, 2023

Choose a reason for hiding this comment

craigsapp commented May 31, 2023 • edited Loading

lpugin commented Jun 17, 2023

WolfgangDrescher commented Jun 19, 2023

WolfgangDrescher commented Jun 19, 2023

craigsapp commented May 31, 2023 •

edited

Loading