Add support for CMME import #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add key signatures for CMME
Custos and multi-event signatures in cmme
* 2 static_cast left in BeamSegment::AdjustBeamToFrenchStyle * 1 static_cast left in BeamSegment::CalcStemDefiningNote
* Used in PAE output
# Conflicts: # src/alignfunctor.cpp
* Remove some duration defines * Remove some uses of DUR_MAX * Adjust code comments
# Conflicts: # src/durationinterface.cpp
# Conflicts: # src/alignfunctor.cpp # src/durationinterface.cpp # src/horizontalaligner.cpp # src/layerelement.cpp
|
I would suggest for this to be merged. Several small things that remain to be adjusted will quite likely need some adjustments to MEI. In the meantime it will be easier if we already have this in the next release. More documentation will be added to the reference book once the release is made. |
ahankinson
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMME files can be imported with
-f cmme.xmlbut should be auto-detected.A CMME file is imported as an MEI mensural file with one single
mdiv/score. Sections in CMME are imported as distinctsectionelements within thescore.Everything in imported as
mensuralnotation, including sections marked asPlainchantin CMME since there is no difference in the way the music is encoded in those sections. Where there is less voices in a section than in the rest of the score, empty and invisible staff elements<staff visibility="false"/>are added to the section.The initial
staffDefelements have no@clef.*and no@keyisgand these are given in thelayerinstead. EverystaffDefcontains amensurindicating that all level of divisions are binary by default.There is one issue listing remaining points to tackle.