Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jmespath module #144

Merged
merged 1 commit into from
Dec 29, 2023
Merged

feat: add jmespath module #144

merged 1 commit into from
Dec 29, 2023

Conversation

luisdavim
Copy link
Contributor

closes #142

@luisdavim luisdavim mentioned this pull request Dec 28, 2023
@luisdavim luisdavim force-pushed the jmespath branch 2 times, most recently from 2c6f8a7 to 5f898bc Compare December 28, 2023 16:44
Signed-off-by: Luis Davim <dluis@vmware.com>
@myzie
Copy link
Collaborator

myzie commented Dec 28, 2023

Nice!

What goes into choosing between these two?

I just want to confirm the usage of the "community" one was intentional, since it seems to be the lesser used one.

@luisdavim
Copy link
Contributor Author

luisdavim commented Dec 28, 2023

The community one seems to be more actively maintained, see also jmespath/go-jmespath#29

The team behind https://kyverno.io/, that uses jmspath, has also joined in maintaining the community fork, before they had their own.

Copy link
Collaborator

@myzie myzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

Comment on lines +29 to +31
.PHONY: tidy
tidy:
find . -name go.mod -execdir go mod tidy \;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

@myzie myzie merged commit 784473e into risor-io:main Dec 29, 2023
@luisdavim luisdavim deleted the jmespath branch December 29, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JmesPath support
2 participants