-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CircleCI jobs for generate and format #177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I first now saw that you're using CircleCI. My bad, will try convert this to CircleCI jobs |
applejag
changed the title
Added GitHub workflows for tests, generate, format
Added CircleCI jobs for generate and format
Jan 27, 2024
In CircleCI, you'll also need to enable running jobs on forks |
luisdavim
reviewed
Jan 27, 2024
@applejag @luisdavim - CircleCI workflows are now enabled for PRs from forks. You can check if you push an update to a branch with a PR. LMK if it doesn't work. |
myzie
approved these changes
Jan 28, 2024
myzie
pushed a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CircleCI jobs to run:
make generate
make format
Run goimports, as some files were not formatted