Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CircleCI jobs for generate and format #177

Merged
merged 9 commits into from
Jan 28, 2024

Conversation

applejag
Copy link
Contributor

@applejag applejag commented Jan 27, 2024

  • Added CircleCI jobs to run:

    • make generate
    • make format
  • Run goimports, as some files were not formatted

@applejag
Copy link
Contributor Author

I first now saw that you're using CircleCI. My bad, will try convert this to CircleCI jobs

@applejag applejag changed the title Added GitHub workflows for tests, generate, format Added CircleCI jobs for generate and format Jan 27, 2024
@applejag
Copy link
Contributor Author

In CircleCI, you'll also need to enable running jobs on forks

Makefile Outdated Show resolved Hide resolved
@myzie
Copy link
Collaborator

myzie commented Jan 28, 2024

@applejag @luisdavim - CircleCI workflows are now enabled for PRs from forks. You can check if you push an update to a branch with a PR. LMK if it doesn't work.

@myzie myzie merged commit 4278b98 into risor-io:main Jan 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants