Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dependencies to Run on Flutter >= 3.10 #31

Merged
merged 15 commits into from
Aug 22, 2023

Conversation

yudha-haris
Copy link
Collaborator

@yudha-haris yudha-haris commented Aug 8, 2023

Thanks for your support to the project. Kindly check and fill below mentioned points

Detailed description of changes

What's New

What's Updated

  • Increase minCompiledSdkVersion to 32 (from 31)
  • Fix floating point overflow in course detail page
  • Fix Tag overflow in course detail page by change Row to Wrap
  • Update dependencies in order to run in Flutter 3.10+

New Package Added

"dependencies": 
  - envied: ^0.3.0+3

"dev_dependencies": 
  - // N / A

Recommendations on how to test the changes

N / A

Checklist for developer

  • The code builds clean without any errors or warnings
  • The code does not contain commented out code
  • The code does not log anything to console
  • I have added unit test(s) to cover new code and successfully executed ran it
  • I have thoroughly tested the new code and any adjacent features it may affect

Link to related issue(s)

N / A

Screenshots or videos (before and after if appropriate)

Before

image

After

image

@yudha-haris yudha-haris changed the title Increasing minCompiledSdkVersion and Fix Overflow in Course Detail Page Upgrade Dependencies to Run on Flutter >= 3.10 Aug 8, 2023
@yudha-haris yudha-haris self-assigned this Aug 10, 2023
@yudha-haris yudha-haris added the enhancement New feature or request label Aug 10, 2023
README.md Outdated
note that automation test doesn't support release mode
```
flutter drive -t test_driver/app.dart --flavor development
flutter pub run build_runner build --delete-conflicting-outputs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flutter pub run build_runner build --delete-conflicting-outputs
dart run build_runner build --delete-conflicting-outputs

Copy link
Collaborator

@fauziridwan1709 fauziridwan1709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fauziridwan1709 fauziridwan1709 merged commit 08614ce into ristekoss:development Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants