Adhere to Java code quality standard #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Storage class has the task creation logic embedded within the textFileToArrayList method. This causes the code to be cluttered and harder to read. Refactoring the task creation logic into separate methods allows others looking at the textFileToArrayList method to easily understand its function. Let's refactor the task creation logic by extracting the following methods: - createTask: Creates Task based on taskSymbol - createTodoTask: Creates Todo Task - createDeadlineTask: Creates Deadline Task - createEventTask: Creates Event Task This approach simplifies the process of adding new Task types in the future, enhances the overall code clarity, and improves readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.