Skip to content

Commit

Permalink
Instance data converters when attached to data binding objects
Browse files Browse the repository at this point in the history
Instead of reusing converters across multiple data bind objects, we are now cloning them.
This simplifies their memory management since we don't need to create data values when a conversion operation takes place.
This also allows to store state on each instance. Which currently allows to store data bound properties instead of fetching them on every frame, and will enable in the future to have time based converters.

Diffs=
baf832a6ce Instance data converters when attached to data binding objects (#8664)
  • Loading branch information
bodymovin committed Dec 9, 2024
1 parent f8a670b commit 6b7b0e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0664f994df49b9cda793a717d4145593f4d56795
baf832a6ce3135bc7f8f8b5cc3695f024610b744
2 changes: 1 addition & 1 deletion wasm/submodules/rive-runtime
Submodule rive-runtime updated 26 files
+1 −1 .rive_head
+7 −1 include/rive/artboard.hpp
+3 −0 include/rive/data_bind/converters/data_converter.hpp
+2 −0 include/rive/data_bind/converters/data_converter_group.hpp
+2 −0 include/rive/data_bind/converters/data_converter_group_item.hpp
+2 −0 include/rive/data_bind/converters/data_converter_operation.hpp
+4 −0 include/rive/data_bind/converters/data_converter_operation_viewmodel.hpp
+3 −0 include/rive/data_bind/converters/data_converter_range_mapper.hpp
+4 −0 include/rive/data_bind/converters/data_converter_rounder.hpp
+4 −0 include/rive/data_bind/converters/data_converter_to_string.hpp
+2 −0 include/rive/data_bind/converters/data_converter_trigger.hpp
+3 −3 include/rive/data_bind/data_bind.hpp
+0 −6 include/rive/data_bind/data_bind_context.hpp
+5 −1 src/animation/state_machine_instance.cpp
+0 −1 src/artboard.cpp
+19 −0 src/data_bind/converters/data_converter_group.cpp
+13 −0 src/data_bind/converters/data_converter_group_item.cpp
+6 −3 src/data_bind/converters/data_converter_operation.cpp
+16 −19 src/data_bind/converters/data_converter_operation_viewmodel.cpp
+9 −6 src/data_bind/converters/data_converter_range_mapper.cpp
+6 −3 src/data_bind/converters/data_converter_rounder.cpp
+8 −5 src/data_bind/converters/data_converter_to_string.cpp
+6 −3 src/data_bind/converters/data_converter_trigger.cpp
+2 −0 src/data_bind/data_bind.cpp
+1 −32 src/data_bind/data_bind_context.cpp
+4 −3 src/importers/backboard_importer.cpp

0 comments on commit 6b7b0e0

Please sign in to comment.