Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge /api/sendgrid and /api/mailgun #5

Open
4 tasks
tomfa opened this issue Aug 26, 2019 · 1 comment
Open
4 tasks

Merge /api/sendgrid and /api/mailgun #5

tomfa opened this issue Aug 26, 2019 · 1 comment

Comments

@tomfa
Copy link
Collaborator

tomfa commented Aug 26, 2019

Endpoints /api/sendgrid/send/<mail> and /api/mailgun/send/<mail> have different behavior

  • sendgrid sends html, mailgun sends plain text. Send html with both?
  • sendgrid html mail does not contain the same text as its text version.
  • sendgrid allows for setting subject and text via GET param. Remove and use content that mailgun uses?
  • Extract sendgrid and mailgun code to a library, and replace api endpoints with /api/email/login/<email>?
@tomfa tomfa changed the title Merge /api/sendgridand /api/mailgun Merge /api/sendgrid and /api/mailgun Aug 26, 2019
This was referenced Aug 26, 2019
Closed
Closed
@rix1
Copy link
Owner

rix1 commented Sep 29, 2019

After thinking briefly I'm implementing the following endpoint auth-now.sh/api/email/

@rix1 rix1 mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomfa @rix1