Rix1/refactor api #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I organized the files according to message content type e.g. plaintext and html
Because of SendGrid's old Node version requirement we want to continue with mailgun and deprecate the SendGrid endpoint
Given a domain name like auth-now.sh this will give us the following API url: `auth-now.sh/api/email/test@domain.com`
To better support future logging to external services
|
Growing impatient so I'm merging this NOW 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a couple of endpoints (hello and sendgrid) and refactors the API to make it more ergonomic:
Old 🧟♂️
/api/email/mailgun/send/test@domain.com/api/email/sendgrid/send/test@domain.com/api/auth/verify/<some-token>/api/data/<some-id>/api/helloNew 💅
/api/email/test@domain.com/api/verify/<some-token>/api/data/<some-id>I also reorganised the
/src/emailfiles according to content type of the email. The motivation for this was to prepare for better HTML support as mentioned in #5.Old 🧟♀️
New 🤸♀️