add default impl for set_rule and set_globals in ninja_target trait (#84

)
rjodinchr · Dec 20, 2024 · 6d290b5 · 6d290b5
1 parent fa6bf93
commit 6d290b5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/src/ninja_target.rs b/src/ninja_target.rs
@@ -37,9 +37,9 @@ pub trait NinjaTarget: std::fmt::Debug {
     fn get_name(&self, prefix: &Path) -> String {
         path_to_id(prefix.join(&self.get_outputs()[0]))
     }
+    fn set_globals(&mut self, _globals: HashMap<String, String>) {}
+    fn set_rule(&mut self, _rules: &NinjaRulesMap) {}
 
-    fn set_globals(&mut self, globals: HashMap<String, String>);
-    fn set_rule(&mut self, rules: &NinjaRulesMap);
     fn get_rule(&self) -> Option<NinjaRule>;
     fn get_inputs(&self) -> &Vec<PathBuf>;
     fn get_implicit_deps(&self) -> &Vec<PathBuf>;

diff --git a/src/ninja_target/cmake.rs b/src/ninja_target/cmake.rs
@@ -37,10 +37,6 @@ impl NinjaTarget for CmakeNinjaTarget {
         }
     }
 
-    fn set_globals(&mut self, _globals: HashMap<String, String>) {}
-
-    fn set_rule(&mut self, _rules: &NinjaRulesMap) {}
-
     fn get_rule(&self) -> Option<NinjaRule> {
         Some(if self.rule.starts_with("CXX_SHARED_LIBRARY") {
             NinjaRule::SharedLibrary

diff --git a/src/ninja_target/meson.rs b/src/ninja_target/meson.rs
@@ -37,10 +37,6 @@ impl NinjaTarget for MesonNinjaTarget {
         }
     }
 
-    fn set_globals(&mut self, _globals: HashMap<String, String>) {}
-
-    fn set_rule(&mut self, _rules: &NinjaRulesMap) {}
-
     fn get_rule(&self) -> Option<NinjaRule> {
         Some(if self.rule == "c_LINKER" || self.rule == "cpp_LINKER" {
             let (_, link_flags) = self.get_link_flags();