Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compileSchemaValidators doesn't expand allOf when failing to merge #3700

Closed
3 of 4 tasks
cwendtxealth opened this issue May 26, 2023 · 0 comments · Fixed by #3701
Closed
3 of 4 tasks

compileSchemaValidators doesn't expand allOf when failing to merge #3700

cwendtxealth opened this issue May 26, 2023 · 0 comments · Fixed by #3701
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned

Comments

@cwendtxealth
Copy link
Contributor

Prerequisites

What theme are you using?

core

Version

5.7.3

Current Behavior

When creating a compiled schema with allOf and it fails to merge, it does not resolve any of the all of schemas to create validators.

Expected Behavior

When compiling schema expected to still resolve allOf schemas even if mergeAllOf fails.

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

No response
@cwendtxealth cwendtxealth added bug needs triage Initial label given, to be assigned correct labels and assigned labels May 26, 2023
cwendtxealth added a commit to cwendtxealth/react-jsonschema-form that referenced this issue May 26, 2023
@cwendtxealth
fix rjsf-team#3700 - Compiling Schema mergeAllOf errors
2f6abe3
@cwendtxealth cwendtxealth mentioned this issue May 26, 2023
Merged
8 tasks
heath-freenome pushed a commit that referenced this issue May 30, 2023
@cwendtxealth
fix #3700 - Compiling Schema mergeAllOf errors (#3701)
eea5bd0 
* fix #3700 - Compiling Schema mergeAllOf errors

* update changelog with fixes

* add soruce comment for ordering json fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #3700 - Compiling Schema mergeAllOf errors cwendtxealth/react-jsonschema-form
1 participant
@cwendtxealth