Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #275: Denote optional field more explicitely. #276

Closed
wants to merge 3 commits into from

Conversation

n1k0
Copy link
Collaborator

@n1k0 n1k0 commented Jul 12, 2016

Refs #275, WiP, cc @kav; patch deployed to gh-pages.

Denoting optional fields instead of required ones, as suggested in these UX guidelines for forms:

uxforms

Edit: revamped the patch with better styling for optional fields. it now prevents the Form root schema field to be considered as optional:

Thoughts?

@n1k0 n1k0 mentioned this pull request Jul 12, 2016
1 task
@n1k0
Copy link
Collaborator Author

n1k0 commented Jul 12, 2016

As if doing this wasn't hard enough already, I asked my twitter followers about that; mixed feelings https://twitter.com/n1k0/status/752908241529483265

@n1k0
Copy link
Collaborator Author

n1k0 commented Jul 13, 2016

Damn, this doesn't help

Maybe we should make it an option (no pun intended)?

@mplis-jetsetter
Copy link
Contributor

In a form with both required and optional fields, I think both strategies work fine. You can argue over which looks better, but they both get the job done. The issues come into play when you have an all-required or an all-optional form.

I think there's definitely potential for confusion with a large all-required form if you're only denoting optional fields. I think the user is likely to not realize that all fields are required, attempt to submit an incomplete form, and be confused/frustrated by the error messages thinking "I didn't know that field was required".

In general, it just makes more sense to me to call out required fields. You're calling the user's attention to fields that require their attention instead of calling their attention to fields that don't require their attention.

@kav
Copy link

kav commented Jul 14, 2016

I think it will vary by use case and in some cases even form to form. See my pull for a bit more flexible alternative that doesn't make a value judgement here

@n1k0
Copy link
Collaborator Author

n1k0 commented Aug 19, 2016

Now #304 has landed, one can easily override how labels are rendered. Discarding this.

@n1k0 n1k0 closed this Aug 19, 2016
@n1k0 n1k0 deleted the 275-better-required-fields branch September 6, 2016 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants