fix: mui/material-ui SelectWidget value undefined
#3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Intendanto Thanks for making the fix. Can you update the |
Nevermind, I'm pushing a fix of my own and will update the |
heath-freenome
approved these changes
Oct 6, 2023
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Oct 6, 2023
…d validator-ajv8 Fixes rjsf-team#3671 by resolving refs inside of `properties` and array `items` and restoring `100%` unit test coverage for `utils` and `validator-ajv8` - Updated `package.json` to add `@types/jest` to the global `devDependencies` - In `@rjsf/utils`, fixed rjsf-team#3671 and restored 100% test coverage as follows: - Updated `jest.config.js` to restore test coverage threshold to 100% - Updated `resolveAllReferences()` to take a new `recurseList: string[]` parameter that is used to prevent recurse `$ref` processing - Return the `schema` directly when it is not an object and also return the original `schema` when the `resolvedSchema` is identical - Updated the `resolveReference()` function to call `resolveAllReferences()` and only call `retrieveSchemaInternal()` when the the `updatedSchema` is different than the original - Updated the `resolveSchema()` function to always call `resolveReference()` and only return the `updatedSchemas` when something was changed - Updated `retrieveSchemaInternal()` to take a new `recurseList: string[] = []` parameter that is passed to `resolveSchema()` and `resolveCondition()` - Updated many of the internal functions to take a `recurseList: string[]` parameter that is forwarded to any function that ultimately calls `retrieveSchemaInternal()` or `resolveAllReferences()` - Updated the `SchemaParser` to properly pass the `recurseList` array to `retrieveSchemaInternal()` and `resolveAnyOrOneOfSchemas()` - Updated the `getClosestMatchingOption()` function to pass an empty array to the `resolveAllReferences()` function for `recurseList` - Updated the `computeDefaults()` function to pass an empty array to the `resolveDependencies()` function for `recurseList` - Also removed an unnecessary `isObject()` check for `formData` in when dealing with `additionalProperties` since it is always guaranteed to be an object - Added/updated tests to ensure that all of the `@rjsf/utils` have 100% test coverage - In `@rjsf/validator-ajv8` to fix tests due to the rjsf-team#3671 changes and restored 100% test coverage as follows: - Updated `jest.config.js` to restore test coverage threshold to 100% - Updated the tests for `precompiledValidator` to call `retrieveSchema()` on the precompiled `rootSchema` to avoid errors caused by the `retrieveSchema()` changes - Updated `validator.ts` to make the `isValid()` call not check if the `rootSchema` already exists (because it doesn't) since the `finally` always removes it - Updated the `validator` tests to restore 100% test coverage - Updated the `CHANGELOG.md` accordingly while also adding the description for rjsf-team#3870
8 tasks
|
@heath-freenome |
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Oct 6, 2023
…d validator-ajv8 Fixes rjsf-team#3671 by resolving refs inside of `properties` and array `items` and restoring `100%` unit test coverage for `utils` and `validator-ajv8` - Updated `package.json` to add `@types/jest` to the global `devDependencies` - In `@rjsf/utils`, fixed rjsf-team#3671 and restored 100% test coverage as follows: - Updated `jest.config.js` to restore test coverage threshold to 100% - Updated `resolveAllReferences()` to take a new `recurseList: string[]` parameter that is used to prevent recurse `$ref` processing - Return the `schema` directly when it is not an object and also return the original `schema` when the `resolvedSchema` is identical - Updated the `resolveReference()` function to call `resolveAllReferences()` and only call `retrieveSchemaInternal()` when the the `updatedSchema` is different than the original - Updated the `resolveSchema()` function to always call `resolveReference()` and only return the `updatedSchemas` when something was changed - Updated `retrieveSchemaInternal()` to take a new `recurseList: string[] = []` parameter that is passed to `resolveSchema()` and `resolveCondition()` - Updated many of the internal functions to take a `recurseList: string[]` parameter that is forwarded to any function that ultimately calls `retrieveSchemaInternal()` or `resolveAllReferences()` - Updated the `SchemaParser` to properly pass the `recurseList` array to `retrieveSchemaInternal()` and `resolveAnyOrOneOfSchemas()` - Updated the `getClosestMatchingOption()` function to pass an empty array to the `resolveAllReferences()` function for `recurseList` - Updated the `computeDefaults()` function to pass an empty array to the `resolveDependencies()` function for `recurseList` - Also removed an unnecessary `isObject()` check for `formData` in when dealing with `additionalProperties` since it is always guaranteed to be an object - Added/updated tests to ensure that all of the `@rjsf/utils` have 100% test coverage - In `@rjsf/validator-ajv8` to fix tests due to the rjsf-team#3671 changes and restored 100% test coverage as follows: - Updated `jest.config.js` to restore test coverage threshold to 100% - Updated the tests for `precompiledValidator` to call `retrieveSchema()` on the precompiled `rootSchema` to avoid errors caused by the `retrieveSchema()` changes - Updated `validator.ts` to make the `isValid()` call not check if the `rootSchema` already exists (because it doesn't) since the `finally` always removes it - Updated the `validator` tests to restore 100% test coverage - Updated the `CHANGELOG.md` accordingly while also adding the description for rjsf-team#3870
heath-freenome
added a commit
that referenced
this pull request
Oct 10, 2023
…or-ajv8 (#3895) Fixes #3671 by resolving refs inside of `properties` and array `items` and restoring `100%` unit test coverage for `utils` and `validator-ajv8` - Updated `package.json` to add `@types/jest` to the global `devDependencies` - In `@rjsf/utils`, fixed #3671 and restored 100% test coverage as follows: - Updated `jest.config.js` to restore test coverage threshold to 100% - Updated `resolveAllReferences()` to take a new `recurseList: string[]` parameter that is used to prevent recurse `$ref` processing - Return the `schema` directly when it is not an object and also return the original `schema` when the `resolvedSchema` is identical - Updated the `resolveReference()` function to call `resolveAllReferences()` and only call `retrieveSchemaInternal()` when the the `updatedSchema` is different than the original - Updated the `resolveSchema()` function to always call `resolveReference()` and only return the `updatedSchemas` when something was changed - Updated `retrieveSchemaInternal()` to take a new `recurseList: string[] = []` parameter that is passed to `resolveSchema()` and `resolveCondition()` - Updated many of the internal functions to take a `recurseList: string[]` parameter that is forwarded to any function that ultimately calls `retrieveSchemaInternal()` or `resolveAllReferences()` - Updated the `SchemaParser` to properly pass the `recurseList` array to `retrieveSchemaInternal()` and `resolveAnyOrOneOfSchemas()` - Updated the `getClosestMatchingOption()` function to pass an empty array to the `resolveAllReferences()` function for `recurseList` - Updated the `computeDefaults()` function to pass an empty array to the `resolveDependencies()` function for `recurseList` - Also removed an unnecessary `isObject()` check for `formData` in when dealing with `additionalProperties` since it is always guaranteed to be an object - Added/updated tests to ensure that all of the `@rjsf/utils` have 100% test coverage - In `@rjsf/validator-ajv8` to fix tests due to the #3671 changes and restored 100% test coverage as follows: - Updated `jest.config.js` to restore test coverage threshold to 100% - Updated the tests for `precompiledValidator` to call `retrieveSchema()` on the precompiled `rootSchema` to avoid errors caused by the `retrieveSchema()` changes - Updated `validator.ts` to make the `isValid()` call not check if the `rootSchema` already exists (because it doesn't) since the `finally` always removes it - Updated the `validator` tests to restore 100% test coverage - Updated the `CHANGELOG.md` accordingly while also adding the description for #3870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #3844
If
enumOptionsdoesnt includevalue-enumOptionsIndexForValuereturnsundefined. Mui/MaterialUi uses (useControlled)[https://github.com/mui/material-ui/blob/master/packages/mui-utils/src/useControlled/useControlled.js#L7C52-L7C52] hook to control whether state of component should be internal or external. Whenundefinedpassed initiallyuseControlledlocks itself with internal state. Thus external updates are ignored. So replacingundefinedwithemptyValue.Checklist
npm run test:updateto update snapshots, if needed.