Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4283 by adding support for MUI v6 #4294

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

heath-freenome
Copy link
Member

Reasons for making this change

Fixed #4283 by adding support for MUI v6

  • Updated @rjsf/mui to update the dev dependencies for @mui/* to v6 and the peer dependencies to add MUI v6
  • Updated the playground to update @mui/* to v6
    • Also changed the dropdown name from material-ui-5 to mui and switched Layout to use the PropsWithChildren for its props
    • Updated the Form.test.tsx to add information to the fake node to allow the tests to work with v6
    • Ran npm run test:update to update the snapshots due to the v6 and emotion upgrades
  • Updated the test snapshots for @rjsf/chakra-ui which also uses emotion
  • Updated CHANGELOG.md accordingly, bumping to 5.21.0

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

- Updated `@rjsf/mui` to update the dev dependencies for `@mui/*` to v6 and the peer dependencies to add MUI v6
- Updated the playground to update `@mui/*` to v6
  - Also changed the dropdown name from `material-ui-5` to `mui` and switched `Layout` to use the `PropsWithChildren` for its props
  - Updated the `Form.test.tsx` to add information to the fake node to allow the tests to work with v6
  - Ran `npm run test:update` to update the snapshots due to the v6 and emotion upgrades
- Updated the test snapshots for `@rjsf/chakra-ui` which also uses emotion
- Updated `CHANGELOG.md` accordingly, bumping to `5.21.0`
@heath-freenome heath-freenome changed the title Fix 4285 by adding support for MUI v6 Fix 4283 by adding support for MUI v6 Sep 10, 2024
Copy link
Contributor

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playground links with material-ui-5 theme encoded in the URL will lose styling since it's now mui, but I think that's ok

@heath-freenome
Copy link
Member Author

heath-freenome commented Sep 10, 2024

Playground links with material-ui-5 theme encoded in the URL will lose styling since it's now mui, but I think that's ok

Hmmm, good point. I wonder if I can keep the selection in the backend, just not show it in the frontend? I updated Playground component to fix that. And tested locally to verify it works

@heath-freenome heath-freenome merged commit 36d2e93 into rjsf-team:main Sep 10, 2024
5 checks passed
@heath-freenome heath-freenome deleted the fix-4283 branch September 10, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MUI v6
2 participants