fix: Short-circuit File and Date constructor access in isObject #4413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This change refactors
isObject
to significantly reduce the frequency of accesses toFile
andDate
by short-circuiting the function with several simple checks prior to runninginstanceof
checks involving the two native classes. The motivation for making this change is explained within the issue this pull request fixes.fixes #4409
Prior
isObject
logicFile
is defined and the value is an instance ofFile
, return falseDate
is defined and the value is an instance ofDate
, return falseNew
isObject
logiclastModified
number property andFile
is defined and the value is an instance ofFile
, return falsegetMonth
method andDate
is defined and the value is an instance ofDate
, return falseChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update
to update snapshots, if needed.