fixed problem getting UNKNOWN state for checking the status of a … #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the patch - please let me verify it on my RHV 4.1 environment. |
|
I'm not sure there might be a better solution. I don't know much about Perl. |
|
Sorry, I have to reject the pull request as it's not possible to get the status of a storage domain. You can only check it via a datacenter. When applying the code, non attached storage domains would be in OK state, which makes the whole status check unnecessary, as it can't reach a non-OK state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Storagedomain
See issue: #3
I checked the if-statement of the check_rhev3.pl version and change the line:
https://github.com/HardTy/check_rhv/blob/0164eb441e18ce215f0e9c32e3dc4b4cf2ab6492/plugin-dir/check_rhv.pl#L742
In my tests the check works with this change.
Sorry my editor removed some spaces at the end of lines.
Regards,
René