Fix/detach handlers on termination #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkallos
reviewed
Jan 18, 2024
test/peep_test.exs
Outdated
|
|
||
| {:ok, pid} = GenServer.start(Peep, options, name: options.name) | ||
|
|
||
| assert length(:telemetry.list_handlers([])) == 1 |
There was a problem hiding this comment.
I'm worried this could fail when tests are run in parallel.
I propose two options:
- Get the handler id using
:sys.get_state(pid), and assert that there is a handler with that id in:telemetry.list_handlers([]) - Create a globally unique metric name, and assert that
:telemetry.list_handlers(MetricName) == 1when the Peep process is running and== 0when the Peep process is terminated.
contested-space
force-pushed
the
fix/detach-handlers-on-termination
branch
from
2d2fd7a to
7d19b13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the event handlers are detached when Peep terminates.