-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to library for OH 4 #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
11 tasks
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Moved minimum OHRT version o 2.0.3
Moved minimum OHRT version to 2.0.3
moved minimum OHRT version 2.0.3
bumping npm version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the code to use OH 4 features, warn about deprecated stuff in logs, and remove unneeded stuff.
timeUtils:
timerMgr:
noop
private by changing the name from_noop
to#noop
getTimerMgr
function and export that as a factory. Usevar tm = TimerMgr()
instead ofvar tm = new timerMgr.TimerMgr()
to instantiate a timer managergetTimerMgr
to index.js as an export toTimerMgr
and added a warning log when one requirestimerMgr
.deferred.js
to use the new factory functiontestUtils:
rulesUtils:
rateLimit:
getRateLimit
function to export . Usevar rl = RateLimit()
instead ofvar rl = new rateLimit.RateLimit()
to instantiateloopingTimer:
getLoopingTimer
function to export. Usevar lt = LoopingTimer()
instead ofvar lt = new loopingTimer.LoopingTimer()
to instantiate.helpers:
const
for constants instead oflet
gatekeeper:
procCommandGenerator
private by changing the_
to the#
getGatekeeper
function to export. Usevar gk = Gatekeeper()
instead ofvar gk = new gatekeeper.Gatekeeper()
to instantiate.deferred:
timerBodyGenerator
private by replacing_
with#
time.toZDT()
to getnow
var d = Deferred()
instead ofvar d = new deferred.Deferred()
to instantiate.countdownTimer:
updateItem
anditerateGenerator
private by replacing_
with#
getCountdownTimer
function to export. Usevar ct = CountdownTimer()
instead ofvar ct = new countdownTimer.CountdownTimer()
to instantiate.I'm going to let these changes sit for a few days in case there is a hidden new bug before merging.