Skip to content

Commit

Permalink
Fix CI failing on commit re-runs (#2319)
Browse files Browse the repository at this point in the history
Allows the CI to pass even if CodeCov upload fails.
This is necessary, because CodeCov fails if the same tests are re-run on the same commit, and there's no good way to tell if that happened.

This change also fixes the mergify config.
  • Loading branch information
krzentner authored Mar 17, 2022
1 parent b4abe07 commit c56513f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 20 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ jobs:
for i in {1..5}; do
bash <(curl -s https://codecov.io/bash --retry 5) -Z && break
if [ $i == 5 ]; then
exit 1
exit 0
else
echo "Retry ${i}..."
sleep 30
Expand Down Expand Up @@ -234,7 +234,7 @@ jobs:
for i in {1..5}; do
bash <(curl -s https://codecov.io/bash --retry 5) -Z && break
if [ $i == 5 ]; then
exit 1
exit 0
else
echo "Retry ${i}..."
sleep 30
Expand Down Expand Up @@ -278,7 +278,7 @@ jobs:
for i in {1..5}; do
bash <(curl -s https://codecov.io/bash --retry 5) -Z && break
if [ $i == 5 ]; then
exit 1
exit 0
else
echo "Retry ${i}..."
sleep 30
Expand Down Expand Up @@ -322,7 +322,7 @@ jobs:
for i in {1..5}; do
bash <(curl -s https://codecov.io/bash --retry 5) -Z && break
if [ $i == 5 ]; then
exit 1
exit 0
else
echo "Retry ${i}..."
sleep 30
Expand Down
24 changes: 8 additions & 16 deletions .mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ pull_request_rules:
- label=ready-to-merge
actions:
merge:
strict: smart
strict_method: rebase
method: squash
rebase_fallback: none
delete_head_branch: {}
- name: Merge queue for master (maintainers)
conditions:
Expand All @@ -45,9 +44,8 @@ pull_request_rules:
- label=ready-to-merge
actions:
merge:
strict: smart
strict_method: rebase
method: squash
rebase_fallback: none
delete_head_branch: {}
- name: Merge for master (docs only)
conditions:
Expand All @@ -62,9 +60,8 @@ pull_request_rules:
- -files~=\.(?!md|rst|png|bib|html|css)
actions:
merge:
strict: smart
strict_method: rebase
method: squash
rebase_fallback: none
delete_head_branch: {}
- name: Merge for master (docs only, maintainers)
conditions:
Expand All @@ -79,9 +76,8 @@ pull_request_rules:
- -files~=\.(?!md|rst|png|bib|html|css)
actions:
merge:
strict: smart
strict_method: rebase
method: squash
rebase_fallback: none
delete_head_branch: {}
- name: Merge queue for release-2019.10
conditions:
Expand All @@ -94,9 +90,8 @@ pull_request_rules:
- label=ready-to-merge
actions:
merge:
strict: smart
strict_method: rebase
method: squash
rebase_fallback: none
delete_head_branch: {}
- name: Merge queue for release-2019.10 (automatic backports)
conditions:
Expand All @@ -108,9 +103,8 @@ pull_request_rules:
- status-success="codecov/patch"
actions:
merge:
strict: smart
strict_method: rebase
method: squash
rebase_fallback: none
delete_head_branch: {}
- name: Merge queue for release-2020.06
conditions:
Expand All @@ -123,9 +117,8 @@ pull_request_rules:
- label=ready-to-merge
actions:
merge:
strict: smart
strict_method: rebase
method: squash
rebase_fallback: none
delete_head_branch: {}
- name: Merge queue for release-2020.06 (automatic backports)
conditions:
Expand All @@ -137,9 +130,8 @@ pull_request_rules:
- status-success="codecov/patch"
actions:
merge:
strict: smart
strict_method: rebase
method: squash
rebase_fallback: none
delete_head_branch: {}
- name: Create backports for v2019.10
conditions:
Expand Down

0 comments on commit c56513f

Please sign in to comment.