-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WiP] Reproducible on- and off-policy sampling #2185
Open
MkuuWaUjinga
wants to merge
7
commits into
rlworkgroup:master
Choose a base branch
from
MkuuWaUjinga:fix/deterministic_sampling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WiP] Reproducible on- and off-policy sampling #2185
MkuuWaUjinga
wants to merge
7
commits into
rlworkgroup:master
from
MkuuWaUjinga:fix/deterministic_sampling
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
a team,
gitanshu and
ziyiwu9494
and removed request for
a team
November 26, 2020 21:17
ryanjulian
reviewed
Dec 4, 2020
ryanjulian
reviewed
Dec 4, 2020
Thanks for the pointers. Addressed everything in the latest commits. I assume GridWorld and PointEnv don't have any seeds at all? |
MkuuWaUjinga
changed the title
[WiP] Deterministic on- and off-policy sampling
[WiP] Reproducible on- and off-policy sampling
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
Environment
API to support setting environment library specific seeds.Tasks:
Environment
interfaceSampler
classes start workingOpen Questions: