Correct implementation of pkgutil style namespace (Fixes #144) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to correct use of pkgutil style namespace packages as documented https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages and illustrated in https://github.com/pypa/sample-namespace-packages/tree/master/pkgutil Note: at the moment the `namespace_packages` directive is completely ignored, if you add the "luma" package to `packages` (in addition to `namespace_packages`) then `setup.py build` returns an error because it is expecting a pkg_resources style namespace package: ``` running build running build_py error: Namespace package problem: luma is a namespace package, but its __init__.py does not call declare_namespace()! Please fix it. (See the setuptools manual under "Namespace Packages" for details.) ``` Note: in the linked example the `find_packages()` method returns the "namespace" package as if it were an ordinary package.
rm-hull
approved these changes
Jul 25, 2018
Gadgetoid
added a commit
to Gadgetoid/luma.oled
that referenced
this pull request
Jul 25, 2018
See corresponding PR to luma.core - rm-hull/luma.core#145 Original issue and explanation - rm-hull/luma.core#144
Gadgetoid
added a commit
to Gadgetoid/luma.led_matrix
that referenced
this pull request
Jul 25, 2018
See corresponding PR to luma.core - rm-hull/luma.core#145 Original issue and explanation - rm-hull/luma.core#144
rm-hull
pushed a commit
to rm-hull/luma.led_matrix
that referenced
this pull request
Jul 25, 2018
* Correct implementation of pkgutil style namespace See corresponding PR to luma.core - rm-hull/luma.core#145 Original issue and explanation - rm-hull/luma.core#144 * Update CONTRIBUTING.rst
|
Based on my sleuthing here rm-hull/luma.oled#215 the following solution may be optimal since it prevents https://github.com/rm-hull/luma.core/compare/master...Gadgetoid:patch-1?expand=1 I'm now attempting to run the tests from: https://github.com/pypa/sample-namespace-packages |
Merged
rm-hull
pushed a commit
to rm-hull/luma.oled
that referenced
this pull request
Sep 7, 2018
* Correct implementation of pkgutil style namespace See corresponding PR to luma.core - rm-hull/luma.core#145 Original issue and explanation - rm-hull/luma.core#144 * Update CONTRIBUTING.rst * Update setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to correct use of pkgutil style namespace packages as documented https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages and illustrated in https://github.com/pypa/sample-namespace-packages/tree/master/pkgutil
See #144 for a longform attempt at explaining this change. The short explanation is that this package confuses the two different methods of implementing namespace packages and this change corrects the implementation to the (Python 2.3+ and Python 3.x compatible) pkgutil style method.
Note: at the moment the
namespace_packagesdirective is completely ignored, if you add the "luma" package topackages(in addition tonamespace_packages) thensetup.py buildreturns an error because it is expecting a pkg_resources style namespace package:Note: in the linked example the
find_packages()method returns the "namespace" package as if it were an ordinary package.