Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support qBittorrent 4.4.0 #60

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Support qBittorrent 4.4.0 #60

merged 1 commit into from
Jan 9, 2022

Conversation

rmartin16
Copy link
Owner

@rmartin16 rmartin16 commented Aug 24, 2021

Fixes #59

Release Checklist

  • Bump version number
  • Update qBittorrent version/link in docs
  • Update CHANGELOG
  • Update qBittorrent version/link in README

Update v4.4.0beta2 in conftest.py to v4.4.0 before merging.

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #60 (2a61685) into master (41b9e28) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   99.77%   99.78%           
=======================================
  Files          14       14           
  Lines        1808     1839   +31     
  Branches      198      201    +3     
=======================================
+ Hits         1804     1835   +31     
  Partials        4        4           
Impacted Files Coverage Δ
qbittorrentapi/definitions.py 100.00% <100.00%> (ø)
qbittorrentapi/torrents.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b9e28...2a61685. Read the comment docs.

@rmartin16 rmartin16 force-pushed the support-4.4.0 branch 19 times, most recently from db127c0 to b573621 Compare August 30, 2021 18:38
@rmartin16 rmartin16 force-pushed the support-4.4.0 branch 5 times, most recently from 4421439 to dd7bc4c Compare October 5, 2021 00:05
@rmartin16 rmartin16 force-pushed the support-4.4.0 branch 5 times, most recently from 12fb4ac to 0295297 Compare October 7, 2021 05:27
@rmartin16 rmartin16 force-pushed the support-4.4.0 branch 5 times, most recently from 86b83a0 to f40ad50 Compare December 12, 2021 17:23
@rmartin16 rmartin16 force-pushed the support-4.4.0 branch 3 times, most recently from c5021ff to 90ccf7c Compare January 2, 2022 22:48
@rmartin16 rmartin16 force-pushed the support-4.4.0 branch 4 times, most recently from f4a1be7 to d0c218d Compare January 7, 2022 17:37
@rmartin16
Copy link
Owner Author

qBittorrent released v4.4.0 rather quickly after merging qbittorrent/qBittorrent#15793....this merge introduced several changes to the web api...some likely unintended (see qbittorrent/qBittorrent#15969 as an example).

I normally try to smooth out qBittorrent API version differences.....but the change of the dictionary key savePath to save_path for torrents/categories stresses the ability for this client to cover that up because of the way HTTP responses are generically processed after getting them back from qBittorrent....so, I don't think I'll easily be able to change save_path back to savePath before returning the dictionary back to calling code.

 - torrents/info results can now be filtered by a torrent tag
 - Added new torrent state "Forced Metadata Downloading"
 - Support per-torrent/per-category "download folder"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qBittorrent Next Release
1 participant