Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to decode responses in python3 #146

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

owenstranathan
Copy link
Contributor

In redis-py on python 3 we have the option to construct our redis class with the kwarg
decode_responses=True which will decode bytes received from redis requests to python 3 strings ('utf-8')

This is really useful behavior because without it we have to decode all bytes before we use them, (not hard but tedious).

This PR adds a setting to enable that behavior in python versions > (3,)

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #146 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   92.85%   92.88%   +0.02%     
==========================================
  Files          18       18              
  Lines         728      731       +3     
  Branches       57       58       +1     
==========================================
+ Hits          676      679       +3     
  Misses         36       36              
  Partials       16       16
Impacted Files Coverage Δ
src/scrapy_redis/connection.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c022d...5db3a3f. Read the comment docs.

@owenstranathan
Copy link
Contributor Author

are there any maintainers for this project?

@sumous
Copy link

sumous commented May 6, 2019

are there any maintainers for this project?

May be not!Should we maintain it?

@rmax rmax merged commit c23a860 into rmax:master Jul 6, 2020
@Germey Germey mentioned this pull request Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants