Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix redis-py dependency version #199

Merged
merged 1 commit into from
Jul 20, 2021
Merged

doc: fix redis-py dependency version #199

merged 1 commit into from
Jul 20, 2021

Conversation

tsonglew
Copy link
Contributor

In redis-py < 3.0, redis.Redis.spop() takes only two arguments which are self and name. But self.fetch_data(self.redis_key, self.redis_batch_size) applies self and two other arguments to self.fetch_data which is redis.Redis.spop() indeed. This could cause an error TypeError: spop() takes 2 positional arguments but 3 were given

Copy link
Owner

@rmax rmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rmax rmax merged commit 32a59d4 into rmax:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants