-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev] Add customize fingerprint #280
Merged
LuckyPigeon
merged 6 commits into
rmax:master
from
LuckyPigeon:dev_customize_fingerprint
Jun 5, 2023
Merged
[dev] Add customize fingerprint #280
LuckyPigeon
merged 6 commits into
rmax:master
from
LuckyPigeon:dev_customize_fingerprint
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rmax |
9 tasks
My suggestion would be to refactor the fingerprint method logic into a function and unit test the behavior of this function:
|
Sounds great. |
@rmax done! |
rmax
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
request_fingerprint
is deprecated inScrapy
, but newfingerprint
function requires a lot of changes of our code. Thus we need a customizefingerprint
implementation for our own.Unittests
are also implemented, there are three newunittests
test_request_seen
withsame_request
diff_method
diff_url
Fixes #272
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: