[1.8] custom introspection #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2017
gjtorikian
reviewed
Dec 11, 2017
spec/graphql/schema/object_spec.rb
Outdated
| @@ -29,6 +29,8 @@ | |||
| name_field = new_object_class.fields.find { |f| f.name == "name" } | |||
| assert_equal "The new description", name_field.description | |||
| end | |||
|
|
|||
| it "inherits name and description" | |||
There was a problem hiding this comment.
added, thanks for the reminder!
This was referenced Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A beast of a PR to add custom introspection to GraphQL-Ruby
__type(name:)&__schema)__typename)I've added docs here.
Fixes #793
Fixes #733
Also, this includes some other interesting stuff:
GraphQL::Schema::LateBoundType: for referencing types by name, this could be nice to make public somehowextras:API for sneaking:irep_nodeand:ast_nodeinto method resolve. Should I document that, or just let it disappear and see if anyone needs it?