-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add redis example #1
Conversation
This is a sample, after all
A lot of stuff broke with this. Most notably, I disabled local cache for the distributed thing forgetting that it's not always the case. We should only disable local cache when there is no In trying to fix it, I started putting everything in the DI container instead of doing the static instances everywhere. That broke it much further, because I don't have a DI container in the tests. Need to figure out how to give xUnit a DI container and register things with it. |
* Switch to properly using DI 🤦♂️ * [WIP] Partially fix tests. No compilation errors, but most tests fail * [WIP] Fix some DI * Allow the caller to send in a cancellation token * Fix removal of items in CacheHelperTests * Remove an impossible test DI now handles the cache, we can't set it anymore * [WIP] ? * Fix SlowDownMiddlewareExtensionsTests/SlowDownOptionsTests * Make many of the middleware integration tests work again * [WIP] Attempting to force a 404 * Fix more tests * Remove `AspNetTestServerFixture`, not used * Make /err work!
Closing PR for the moment. Finishing up some code coverage stuff, then I need to make sure the standalone still works fine then test this branch with Aspire/Redis/Docker again. |
A window of 0 is invalid for HybridCache and causes an exception.
I've tried having I've asked on Bluesky (no responses yet) and dug through a bunch of the HybridCache code, including DefaultHybridCache.cs. I may just be missing something obvious. Quitting for the night and coming back with fresh eyes tomorrow. cc @rbenoit this is the one and only thing left at this point, if you're free to work on it tomorrow go forth |
No description provided.