Use metro & babel config to run example without library packing #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfazekas
force-pushed
the
no-pack-in-example
branch
2 times, most recently
from
4e78eb9
to
31e50f9
Compare
|
This is great stuff! Also, man I love your commitment to this library... Wish I could do more but I don't have the time. This PR should fix some common hurdless when contributing & switching branches 👌 My experience is that stuff kept getting out of sync, especially with generated code. |
mfazekas
force-pushed
the
no-pack-in-example
branch
from
31e50f9
to
44e4677
Compare
Let me just second that - thanks for going the extra mile Miklós 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metro and babel magic to avoid packing rnmbgl when running the example. This means that source code can be edited on place, without editing a copy then using some means to sync it(wml sync, symlink etc)
Method copied from
react-native-reanimated, the downside is that RNMBGL deps had to be added to example and babel.config too.