-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to use clang-format 11.0.0. #1974
Conversation
No, it was not done by intention |
Codecov ReportBase: 81.94% // Head: 81.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1974 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 142 142
Lines 29225 29246 +21
=======================================
+ Hits 23947 23966 +19
- Misses 5278 5280 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -46,7 +46,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
os: [macos-10.15, macos-11.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ni4 if the macOS builds work then we can close both:
Thanks! |
@ronaldtse yeah, let's just wait for the macOS 12 jobs to be picked up and handled. |
ecbfee1
to
c1fe95c
Compare
Merging as this is just CI change and all is green. |
Commit 793e5b3 updates lint.yml for clang-format action, which started to use version 11.1.0 instead 11.0.0 by default, so this PR reverts this back to 11.0.0.
Also it updates macOS version runners.
@maxirmx Was this done by intension, i.e. are there any benefits of switching to 11.1.0? I'm not against it but just want to get aligned/update work setup.
Fixes #1975
Fixes #1976