Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use clang-format 11.0.0. #1974

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Jan 23, 2023

Commit 793e5b3 updates lint.yml for clang-format action, which started to use version 11.1.0 instead 11.0.0 by default, so this PR reverts this back to 11.0.0.
Also it updates macOS version runners.

@maxirmx Was this done by intension, i.e. are there any benefits of switching to 11.1.0? I'm not against it but just want to get aligned/update work setup.

Fixes #1975
Fixes #1976

@maxirmx
Copy link
Member

maxirmx commented Jan 23, 2023

@maxirmx Was this done by intension, i.e. are there any benefits of switching to 11.1.0? I'm not against it but just want to get aligned/update work setup.

No, it was not done by intention

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 81.94% // Head: 81.94% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c1fe95c) compared to base (cffcace).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1974   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         142      142           
  Lines       29225    29246   +21     
=======================================
+ Hits        23947    23966   +19     
- Misses       5278     5280    +2     
Impacted Files Coverage Δ
src/lib/crypto/backend_version.cpp 100.00% <ø> (ø)
src/rnp/rnpcfg.cpp 82.77% <ø> (ø)
src/rnp/fficli.cpp 81.24% <0.00%> (-0.04%) ⬇️
src/rnp/rnp.cpp 81.63% <0.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -46,7 +46,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macos-10.15, macos-11.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronaldtse
Copy link
Contributor

@ni4
Copy link
Contributor Author

ni4 commented Jan 24, 2023

@ronaldtse yeah, let's just wait for the macOS 12 jobs to be picked up and handled.

@ni4 ni4 force-pushed the ni4-fix-ci-to-use-clang-format-11-0-0 branch from ecbfee1 to c1fe95c Compare January 25, 2023 11:43
@ni4
Copy link
Contributor Author

ni4 commented Jan 25, 2023

Merging as this is just CI change and all is green.

@ni4 ni4 merged commit 0c13012 into master Jan 25, 2023
@ni4 ni4 deleted the ni4-fix-ci-to-use-clang-format-11-0-0 branch January 25, 2023 15:01
@ni4 ni4 added this to the v0.17.0 milestone Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants